Support exclude in coredumpy.patch_except #88
Conversation
src/coredumpy/except_hook.py
Outdated
| _original_excepthook = sys.excepthook | ||
|
|
||
|
|
||
| def patch_except(path: Optional[Union[str, Callable[[], str]]] = None, | ||
| directory: Optional[str] = None): | ||
| directory: Optional[str] = None, | ||
| exclude: Optional[List[BaseException]] = None): |
There was a problem hiding this comment.
Let's use Sequence rather than List here for type hint. You are converting it to tuple and there's no reason to force it to be a list. Also Exception might be better here because I don't believe SystemExit is caught on sys.excepthook.
An alternative to Sequence is just tuple - immutable is a good thing. You are lazy evaluating this and if it's mutable, it could be changed unexpectedly.
Also, do some sanity check for the argument. We want error out early if what user passes is wrong, not wait until it is evaluated.
There was a problem hiding this comment.
I use Iterable instead and make it immutable internally.
KeyboardInterrupt is a subclass of BaseException but not Exception. I believe that most use case for this exclude will be KeyboardInterrupt, so I preserve it there.
PTAL.
No description provided.