8000 Fix Windows installer build by Abestanis · Pull Request #561 · gyunaev/birdtray · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Windows installer build #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

Abestanis
Copy link
Collaborator

This pins the NSIS version, because newer version break our nsis scripts. I tested that this works on a fork.

After merging this we should either create a new version or delete the tag of the current latest version and push a new tag.

Fixes #560.

@Abestanis Abestanis requested a review from gyunaev August 31, 2023 00:53
@Abestanis Abestanis self-assigned this Aug 31, 2023
@gyunaev gyunaev merged commit e065101 into gyunaev:master Aug 31, 2023
@Abestanis Abestanis deleted the fix/installer_build branch August 31, 2023 01:00
@Abestanis
Copy link
Collaborator Author

@gyunaev can you either create a new version or delete the tag of the current latest version and push a new tag?

@gyunaev
Copy link
Owner
gyunaev commented Aug 31, 2023

Retagged as 1.11.1.

@Abestanis
Copy link
Collaborator Author

Looks like the CI created a release as a Draft with the installers attached, but you also created a release manually without them. Can we just remove the manually created release an undraft the automatically generated one?

@gyunaev
Copy link
Owner
gyunaev commented Aug 31, 2023

Done.

@Abestanis
Copy link
Collaborator Author

Thanks, we forgot to increase the patch version, but it's fine, we'll do it the next release. We should create a wiki page on how to do a release, so we don't forget for next time 😄

@MChaos45
Copy link

The update is reported as 1.11.2, but the download is 1.11.0.

But there's a bigger problem (on my machine, 64 bit Windows 10) is that the 32 bit installer works fine, but the 64 bit installer doesn't work (nothing happens, just shows up in task manager for a few seconds, but no window or error message).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

precompiled installers for the latest release is missing
3 participants
0