8000 Update pycbc.inference documentation by cmbiwer · Pull Request #1420 · gwastro/pycbc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update pycbc.inference documentation #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 9, 2017
Merged

Conversation

cmbiwer
Copy link
Contributor
@cmbiwer cmbiwer commented Feb 3, 2017

This updates the pycbc.inference documentation page examples and adds an example how to read real data and how to use pycbc_inference_plot_posterior.

Trying to address a number of things that RIT @a-r-williamson brought up last week.

@stevereyes01 can you take a look at this page as well and if something doesn't make sense them let me know.

Afterwards I'll probably end up assigning this to @cdcapano once @stevereyes01 has given me some feedback.

An example of the rendered documentation is here: https://sugwg-jobs.phy.syr.edu/~cbiwer/docs/inference.html

< 8000 div id="js-timeline-progressive-loader" data-timeline-item-src="gwastro/pycbc/timeline_focused_item?after_cursor=Y3Vyc29yOnYyOpPPAAABYk942hgBqjE1MzY1NzQ1NDI%3D&id=MDExOlB1bGxSZXF1ZXN0MTA0NTk4NzMw" >
@ahnitz
Copy link
Member
ahnitz commented Feb 4, 2017

This page doesn't seem right. Also you don't seem to have committed a distributions.rst file. https://sugwg-jobs.phy.syr.edu/~cbiwer/docs/distributions.html

@stevereyes01
Copy link
Contributor

@cmbiwer I'll have a look over this, sorry I just saw this today.

@stevereyes01
Copy link
Contributor

One minor comment, there's still that nagging line:
fp = InferenceFile("cbc_example-n1e4.hdf.hdf", "r")

Other than that, I think it looks good at my first pass over it.

If you think it would help, it may not hurt to put some examples of the plots referenced in this documentation. I've seen a bunch of them before, so I don't think I would need to see them. I'll leave that to your discretion.

@cdcapano
Copy link
Contributor
cdcapano commented Feb 9, 2017

@cmbiwer Just want to say, I like that you have the suggested options to be the skip-burn-in. People keep asking me about how long it's supposed to take before they can see results because they have kombine's burn-in turned on, and I keep telling them to turn that off. I was going to file a PR to change that in the docs, but then saw you had already addressed it.

@cmbiwer
Copy link
Contributor Author
cmbiwer commented Feb 9, 2017

I've corrected the typo that Steven pointed out. But Steven please take a closer look at this documentation. You should understand everything on the page.

@ahnitz
Copy link
Member
ahnitz commented Feb 9, 2017

@cmbiwer Have you fixed the generation of this page? https://sugwg-jobs.phy.syr.edu/~cbiwer/docs/distributions.html

@duncan-brown duncan-brown added this to the v1.6.5 Release milestone Feb 9, 2017
@cmbiwer
Copy link
Contributor Author
cmbiwer commented Feb 9, 2017

I've fixed the issues with the distributions documentation page: https://sugwg-jobs.phy.syr.edu/~cbiwer/docs/distributions.html

I'll assign this to @duncan-brown for now but @stevereyes01 and @cdcapano I'll make an issue and if you want me to make other changes please make those requests in the issue.

@cmbiwer
Copy link
Contributor Author
cmbiwer commented Feb 9, 2017

Landscape problem is a landscape Server Error.

@duncan-brown duncan-brown merged commit b688327 into gwastro:master Feb 9, 2017
cmbiwer added a commit to cmbiwer/pycbc that referenced this pull request Feb 21, 2017
* Add distributions to index.

* Rewrite inference intro.

* Update intro.

* Make list.

* Update docs.

* Update config file docs.

* List parameters.

* Update example scripts.

* Fix label.

* Add real data example.

* Remove sngl workflow documentation.

* Fix file extension typo.
hagabbar pushed a commit to hagabbar/pycbc_copy that referenced this pull request May 24, 2017
* Add distributions to index.

* Rewrite inference intro.

* Update intro.

* Make list.

* Update docs.

* Update config file docs.

* List parameters.

* Update example scripts.

* Fix label.

* Add real data example.

* Remove sngl workflow documentation.

* Fix file extension typo.
duncanmmacleod pushed a commit to gwastro/gwin that referenced this pull request Mar 19, 2018
* Add distributions to index.

* Rewrite inference intro.

* Update intro.

* Make list.

* Update docs.

* Update config file docs.

* List parameters.

* Update example scripts.

* Fix label.

* Add real data example.

* Remove sngl workflow documentation.

* Fix file extension typo.
duncanmmacleod pushed a commit to gwastro/gwin that referenced this pull request Mar 19, 2018
* Add distributions to index.

* Rewrite inference intro.

* Update intro.

* Make list.

* Update docs.

* Update config file docs.

* List parameters.

* Update example scripts.

* Fix label.

* Add real data example.

* Remove sngl workflow documentation.

* Fix file extension typo.
duncanmmacleod pushed a commit to gwastro/gwin that referenced this pull request Mar 22, 2018
* Add distributions to index.

* Rewrite inference intro.

* Update intro.

* Make list.

* Update docs.

* Update config file docs.

* List parameters.

* Update example scripts.

* Fix label.

* Add real data example.

* Remove sngl workflow documentation.

* Fix file extension typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0