iDQ workflow code shouldn't look for ifos that aren't there #5077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spxiwh
added a commit
to spxiwh/pycbc
that referenced
this pull request
Mar 13, 2025
spxiwh
added a commit
that referenced
this pull request
Mar 13, 2025
* possible f_low bug in decompressed wf (#5074) * Resolve_url for the cache file (#5075) * Resolve_url for the cache file * Resolve_url doesnt work for None * Don't look for ifos that aren't there (#5077) * Bump release number --------- Co-authored-by: Thomas Dent <thomas.dent@usc.es> Co-authored-by: Gareth S Cabourn Davies <gareth.cabourndavies@ligo.org>
GarethCabournDavies
pushed a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
May 12, 2025
khunsang
pushed a commit
to khunsang/pycbc
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The all-sky workflow code is setup so that the
workflow-ifossection of the config should be the only place that decides what ifos are active. If (for example) that section lists h1 and v1, then sections labelledl1elsewhere in the config file should be ignored ... They should also not break anything (ie. havingl1sections should be fine, they just won't be used). This then means that if I want to swap to a L1 V1 analysis I just turn L1 on and remove h1 fromworkflow-ifos.At the moment the iDQ workflow code breaks this, by searching for section names (and not checking if they are actually being used). The fix is trivial, just do an "AND" operation, with
workflow-ifoswhen iDQ figures out which ifos are present. This still allows the functionality that if there is not a "workflow-iDQ-v1" section, we will not try to do V1 iDQ things, even if V1 is active.