8000 Address ci deprecations by titodalcanton · Pull Request #5076 · gwastro/pycbc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Address ci deprecations #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

Address ci deprecations #5076

merged 3 commits into from
Mar 17, 2025

Conversation

titodalcanton
Copy link
Contributor
@titodalcanton titodalcanton commented Mar 10, 2025 •
edited
Loading

I noticed a couple recent deprecations related to our CI tests. This should address them.

One is the version of Ubuntu: actions/runner-images#11101.

The other one is the Python version used to build the distribution workflow:

cibuildwheel 3 will require Python 3.11+, please upgrade the Python version used to run cibuildwheel. This does not affect the versions you can target when building wheels. See: https://cibuildwheel.pypa.io/en/stable/#what-does-it-do

  • The author of this pull request confirms they will adhere to the code of conduct

@GarethCabournDavies GarethCabournDavies mentioned this pull request Mar 14, 2025
Closed
@titodalcanton
Copy link
Contributor Author
titodalcanton commented Mar 16, 2025 •
edited
Loading

Hmm, some of the tests are failing, apparently due to this:

2025-03-16T16:30:43.3635028Z Traceback (most recent call last):
2025-03-16T16:30:43.3661816Z   File "/home/runner/work/pycbc/pycbc/examples/live/./check_results.py", line 14, in <module>
2025-03-16T16:30:43.3662633Z     from ligo.skymap.io import LigoLWEventSource
2025-03-16T16:30:43.3663615Z   File "/home/runner/work/pycbc/pycbc/.tox/py-search/lib/python3.9/site-packages/ligo/skymap/io/__init__.py", line 9, in <module>
2025-03-16T16:30:43.3664666Z     exec('from . import {0};'
2025-03-16T16:30:43.3665056Z   File "<string>", line 1, in <module>
2025-03-16T16:30:43.3665947Z   File "/home/runner/work/pycbc/pycbc/.tox/py-search/lib/python3.9/site-packages/ligo/skymap/io/fits.py", line 70, in <module>
2025-03-16T16:30:43.3666771Z     from .. import moc
2025-03-16T16:30:43.3667526Z   File "/home/runner/work/pycbc/pycbc/.tox/py-search/lib/python3.9/site-packages/ligo/skymap/moc.py", line 36, in <module>
2025-03-16T16:30:43.3668500Z     from .core import nest2uniq, uniq2nest, uniq2order, uniq2pixarea, uniq2ang
2025-03-16T16:30:43.3669761Z ImportError: /home/runner/work/pycbc/pycbc/.tox/py-search/lib/python3.9/site-packages/ligo/skymap/core.abi3.so: undefined symbol: gsl_root_fdfsolver_steffenson

I am going to try a less aggressive update to ubuntu-22.

Edit: I suspect this is due to ligo.skymap no longer supporting Python 3.9. If this is the case, we should be able to go all the way to ubuntu-24 once we drop the 3.9 tests.

@titodalcanton titodalcanton added the github_actions Pull requests that update GitHub Actions code label Mar 16, 2025
@titodalcanton
Copy link
Contributor Author

The Mac tests were also failing, but they are passing after clearing the CI cache.

@titodalcanton titodalcanton requested a review from spxiwh March 16, 2025 21:41
GarethCabournDavies
GarethCabournDavies approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor
@GarethCabournDavies GarethCabournDavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues, and the CIs are passing

@titodalcanton
Copy link
Contributor Author

It seems the branch protection rules are somehow bound to the old versions of the tests, which will not run anymore. I guess I will temporarily remove those requirements, merge this, and then re-enable them with the new tests.

@titodalcanton titodalcanton merged commit 85b0f22 into gwastro:master Mar 17, 2025
31 checks passed
@titodalcanton titodalcanton deleted the address-ci-deprecations branch March 17, 2025 14:14
yi-fan-wang pushed a commit to yi-fan-wang/pycbc that referenced this pull request Mar 28, 2025
@titodalcanton @yi-fan-wang
Address ci deprecations (gwastro#5076)
4518908 
* Update CI to Ubuntu 24.04

* Use Python 3.11 for distribution CI

* Try ubuntu-22 for basic tests
GarethCabournDavies pushed a commit to GarethCabournDavies/pycbc that referenced this pull request May 12, 2025
@titodalcanton @GarethCabournDavies
Address ci deprecations (gwastro#5076)
c01a294 
* Update CI to Ubuntu 24.04

* Use Python 3.11 for distribution CI

* Try ubuntu-22 for basic tests
spxiwh pushed a commit to spxiwh/pycbc that referenced this pull request May 12, 2025
@titodalcanton @spxiwh
Address ci deprecations (gwastro#5076)
47017b8 
* Update CI to Ubuntu 24.04

* Use Python 3.11 for distribution CI

* Try ubuntu-22 for basic tests
spxiwh added a commit that referenced this pull request May 12, 2025
@spxiwh @titodalcanton @ahnitz
Changes for v2.3.13 release (#5126)
f1208f1 
* Update PyPI publish action (#5097)

* Workaround for git.ligo.org authentication change (#5119)

* Workaround for git.ligo.org auth change

* Workaround for git.ligo.org auth change

* Forgot args

* Fix error

* Two possible URL schemes

* Fix regex

* Don't miss this bit!

* Address ci deprecations (#5076)

* Update CI to Ubuntu 24.04

* Use Python 3.11 for distribution CI

* Try ubuntu-22 for basic tests

* updated for depcreated fillcolor value (#5123)

* Update cibuildwheel to v311

* Pin cython version

* Bump pegasus versions to 5.0.8

* Fix strange usage of pycbc.version.release (#5033)

* Fix usage of release flag in Pegasus sites code (#5098)

---------

Co-authored-by: Tito Dal Canton <tito.dalcanton@ijclab.in2p3.fr>
Co-authored-by: Alex Nitz <alex.nitz@gmail.com>
khunsang pushed a commit to khunsang/pycbc that referenced this pull request May 23, 2025
@titodalcanton
Address ci deprecations (gwastro#5076)
59b0146 
* Update CI to Ubuntu 24.04

* Use Python 3.11 for distribution CI

* Try ubuntu-22 for basic tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarethCabournDavies GarethCabournDavies GarethCabournDavies approved these changes

@spxiwh spxiwh Awaiting requested review from spxiwh

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titodalcanton @GarethCabournDavies
0