Changes for v2.3.10 #5044
Merged
Changes for v2.3.10 #5044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need:
|
1 task
|
Here's the PR #5052 to incorporate the FAR plot in the workflow. |
spxiwh
commented
Feb 19, 2025
8000
* Add compressed waveforms to bank workflow * Allolw plotting script to use any bank conversion parameter * Some fixes to allow the joined bank to be plotted * Use inference's parameter labels: they are available and mostly good * Add mismatch to plotting, make some tweaks * some tidying * thinko * Try to make the CI workflow run * Fix do-not-compress default * Use different examples in compress bank workflow * Proper name for the github workflow * Thinko * python shebang in compression workflow script * minor edits * move to readily-available waveform * TRy IMRPhenomD instead * revert change to workflow.core * Warn for KeyError in get_decompressed_waveform * Fix issue with if get_decompressed_waveform raised a ValueError
029553d to
0618710
Compare
There was a problem hiding this comment.
I think this incorporates everything, at least everything with the label
Does #5047 need adding as well (@tdent?) Apart from that, if I assume everything was merged that needed it in v2.3.9, then I think this is all good
I've added a little bit to #5064 on top of what is here, but it isn't super important
|
#5047 is not expected to be used for production analysis. |
GarethCabournDavies
approved these changes
Feb 27, 2025
|
Maybe worth waiting for the stat plot x axis limits fix .. incoming soon |
* added plot script * cleanups * remove now unused bits * Generalize fit plotting * rename script
0618710 to
49245a7
Compare
|
I've included that patch now |
49245a7 to
a2bf609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few tweaks that are needed for the v2.3 release branch. I'll track these here, not yet ready for merging.