Refresh from nickbnf/glogg #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation is incomplete and does not deal well with deletion / renaming.
CONFIG += c++11 does this already and it has been supported since at least Qt 5.4.0 / qmake 3.0, ref https://wiki.qt.io/index.php?title=How_to_use_C%2B%2B11_in_your_Qt_Projects&oldid=18324.
Instead of just being a shared_ptr with a dummy value, we store the this-pointer in it, which makes the closure in addWatchedDirectory smaller since we can use the weak_ptr in favor of additionally passing in the ObservedFileList-pointer. As a bonus, this may make the intent of the heartBeat_ more clear.
Project file fixes
Fix race-condition with ObservedFileList::cleanRefsToExpiredDirs.
allow multiple files drop
Previously it would attempt to select the current index, which is empty then.
Disable useless FiltersDialog buttons if no filter is selected.
When removing filters at the end, select the previous filter
Allow to get out of some situation where the file has changed but glogg didn't register it.
Additional encodings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.