Use Buffer for huge XML support #386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjhbw
pushed a commit
that referenced
this pull reques
ACA4
t
Sep 25, 2024
brijeshbv
pushed a commit
to BrandonDR/docx-templates
that referenced
this pull request
Nov 13, 2024
… XML support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to generate an xml file with a total length greater than v8 allows (38 GB, and v8 only allows you to put 8 in a string), and these changes helped me not catch the “Range Error: Invalid string length” error.
All tests passed with the exception of 4 tests on error handlers, but this was unrelated to my changes.
If possible, I would like the library to support huge files.