feat: Implement watermark text replacement and update snapshots #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjhbw
reviewed
Jun 3, 2025
jjhbw
reviewed
Jun 3, 2025
|
Commit 3831d57 has been added to address your review. All tests run and passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem this solves or feature it adds: This PR adds the capability to dynamically replace text within DOCX watermarks using template commands.
Key changes: Modified
processTemplate.tsto handle VML textpath string attributes, ensuring command processing occurs with isolated context. Added new tests intemplating.test.tswith a sample watermarked document (watermarked.docx) and updated snapshots.How it was tested: All existing tests pass, and new tests specifically covering watermark replacement also pass. Snapshots have been updated.