10000 fix: corrupted docx issue caused by duplicate extensions in ContentType.xml with different casing by ACHP · Pull Request #400 · guigrpa/docx-templates · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: corrupted docx issue caused by duplicate extensions in ContentType.xml with different casing #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2025
Merged

fix: corrupted docx issue caused by duplicate extensions in ContentType.xml with different casing #400

merged 2 commits into from
Mar 9, 2025

Conversation

ACHP
Copy link
Contributor
@ACHP ACHP commented Jan 28, 2025 •
edited
Loading

Description

This PR addresses a bug where the ContentType.xml file could be corrupted due to duplicate entries of the same file extension with different casing. For example, if a template specifies an uppercase extension (JPG), but the generated report inserts a lowercase extension (jpg), the ContentType.xml ends up with two entries:

<Default Extension="JPG" ContentType="image/jpeg"/>
<Default Extension="jpg" ContentType="image/jpeg"/>

As a result, the DOCX file becomes invalid.
image

Solution

To fix this issue, we updated the ensureContentType function to be case-insensitive when adding new extensions. This change ensures that only one entry is created for a given extension, regardless of its casing.

Changes
• Updated ensureContentType to treat extensions in a case-insensitive manner.

How to reproduce:

  • Create a docx file with a JPG image in it, (make sure the extension is uppercase)
  • Use it as a templte to insert a jpg (lowercase) image
  • open the docx

@ACHP ACHP changed the title write initial test fix: Avoid dupplicating extension in the ContentType.xml file corrupt the docx Jan 28, 2025
@ACHP ACHP changed the title fix: Avoid dupplicating extension in the ContentType.xml file corrupt the docx fix: corrupted docx issue caused by duplicate extensions i A1D5 n ContentType.xml with different casing Jan 28, 2025
@ACHP ACHP marked this pull request as ready for review January 28, 2025 10:07
@jjhbw
Copy link
Collaborator
jjhbw commented Mar 9, 2025

Thanks! Great work. Sorry for the late reply.

@jjhbw jjhbw merged commit 02e289f into guigrpa:master Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ACHP @jjhbw
0