use fancy-regex instead of onig as tokenizers regex library #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oniguruma doesn't build on GCC 15 and the project got archived last week, so this PR switches to the fancy-regex backend. `fancy-regex` also requires flipping on the `unstable_wasm` feature until huggingface/tokenizers#1772 lands. Right now that flag doesn't have any ill effects since everything WASM related downstream is behind `target_arch` checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of Oniguruma used in
onig_sysdoesn't build on GCC 15 and the oniguruma project itself got archived last week, so this PR switches tokenizers to the fancy-regex backend.fancy-regexalso requires flipping on theunstable_wasmfeature until huggingface/tokenizers#1772 lands, that flag doesn't have any ill effects though since everything WASM related downstream is behindtarget_archchecks.tl;dr: This fixes builds on Linux distros with newer GCC versions like Arch Linux and Fedora.