Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: 리팩토링 #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: 리팩토링 #152
Changes from all commits
a104053
997b96c
7698964
7d06ae0
ad6bd87
f245104
8260d24
a8eed27
674b37b
23003fe
3f97f8a
d26e3c5
49aad85
98b1643
222edaa
ffce8a2
cd865f6
ba4e7d2
5effc82
0e984fe
f3cea97
c36ae28
3387b08
c65a9d2
3a7260c
8a67cf6
1bcbaf5
d3b102d
332c990
6e4f530
b4b7da1
8b13f87
6fd9acf
04d5dd7
0d75066
754ac33
e66b39b
a43e8ae
6d59902
7c474c1
30c97d8
dbcb5ec
8d035c2
22293f6
e947836
413f8c0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
handleCancelClick 함수에서 dialog 닫기 로직 누락
handleCancelClick 함수에서 로컬 스토리지 값만 설정하고 dialog를 닫지 않고 있습니다. 사용자 경험 향상을 위해 closeDialog() 함수도 호출해야 합니다.
다음과 같이 수정해주세요:
const handleCancelClick = () => { setLocalStorageTrue('install'); + closeDialog(); };
📝 Committable suggestion