Added direct/indirect/unknown enum for IsDependency and update deps.dev collector/parser #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxp928
commented
Apr 25, 2023
a622f84 to
2bd790a
Compare
mihaimaruseac
approved these changes
Apr 25, 2023
|
Ready for review. Removes scorecard compare from unit tests to ensure the CI doesnt break each time it changes in deps.dev (fixes Update deps.dev unit tests to be more resilient #740) |
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
Signed-off-by: pxp928 <parth.psu@gmail.com>
9e6a9de to
f24af60
Compare
Signed-off-by: pxp928 <parth.psu@gmail.com>
f24af60 to
71ef533
Compare
trmiller
approved these changes
Apr 25, 2023
mlieberman85
pushed a commit
to mlieberman85/artifact-ff
that referenced
this pull request
Jul 5, 2023
…ev collector/parser (guacsec#778) * add dependencyType to IsDependency and update resolvers Signed-off-by: pxp928 <parth.psu@gmail.com> * update parsers to add dependencyType Signed-off-by: pxp928 <parth.psu@gmail.com> * update deps.dev to follow direct and indirect dependencies Signed-off-by: pxp928 <parth.psu@gmail.com> * remove cyclical error Signed-off-by: pxp928 <parth.psu@gmail.com> * change to unknwon for dependencyType, remove old document from TODO Signed-off-by: pxp928 <parth.psu@gmail.com> * if edge.requirement is , replace with the version of the ToNode package Signed-off-by: pxp928 <parth.psu@gmail.com> * remove scorecard check from unit tests Signed-off-by: pxp928 <parth.psu@gmail.com> --------- Signed-off-by: pxp928 <parth.psu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address Issue #769
Closes #748