8000 Add NoKnownVuln node and related operations. by mihaimaruseac · Pull Request #673 · guacsec/guac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add NoKnownVuln node and related operations. #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 5, 2023
Merged

Add NoKnownVuln node and related operations. #673

merged 7 commits into from
Apr 5, 2023

Conversation

mihaimaruseac
Copy link
Collaborator
@mihaimaruseac mihaimaruseac commented Apr 4, 2023 •
edited
Loading

This is to signal that when running a vuln certifier a specific package was found to not have any vulnerability.

Signed-off-by: Mihai Maruseac mihaimaruseac@google.com

@mihaimaruseac mihaimaruseac requested review from lumjjb and pxp928 April 4, 2023 22:29
lumjjb
lumjjb reviewed Apr 4, 2023
View reviewed changes
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Apr 5, 2023
@mihaimaruseac mihaimaruseac force-pushed the no-known-vuln branch 2 times, most recently from 7159b8a to 08b7023 Compare April 5, 2023 17:21
@mihaimaruseac
Add NoKnownVuln node and related operations.
793fba8 
This is to signal that when running a vuln certifier a specific package
was found to not have any vulnerability.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Remove the new ingestion methods
060b300 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Rename OsvCveOrGhsa to Vulnerability to prepare for adding new node
ee47b67 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Schema changes to add NoVuln node
bccc779 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Generated code
4c4aba9 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Use the singleton NoVuln node
b26f1fe 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Import fix
252e16d 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
pxp928
pxp928 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator
@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure we should remove the existing union type.

mihaimaruseac added a commit to mihaimaruseac/guac that referenced this pull request Apr 5, 2023
@mihaimaruseac
Allow filtering neighbors and paths on GUAC verbs
1d0d051 
We can expand it if we want to also filter on the other neighbors, it
ended up being quite generic.

Depends on guacsec#673.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac mihaimaruseac mentioned this pull request Apr 5, 2023
Merged
mihaimaruseac added a commit to mihaimaruseac/guac that referenced this pull request Apr 5, 2023
@mihaimaruseac
Allow filtering neighbors and paths on GUAC verbs
11b6a3d 
We can expand it if we want to also filter on the other neighbors, it
ended up being quite generic.

Depends on guacsec#673.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac added a commit to mihaimaruseac/guac that referenced this pull request Apr 5, 2023
@mihaimaruseac
Allow filtering neighbors and paths on GUAC verbs
fd285d0 
We can expand it if we want to also filter on the other neighbors, it
ended up being quite generic.

Depends on guacsec#673.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@kodiakhq kodiakhq bot merged commit 6ab04cd into guacsec:main Apr 5, 2023
@mihaimaruseac mihaimaruseac deleted the no-known-vuln branch April 5, 2023 23:03
mihaimaruseac added a commit to mihaimaruseac/guac that referenced this pull request Apr 5, 2023
@mihaimaruseac
Allow filtering neighbors and paths on GUAC verbs
c7fd5e3 
We can expand it if we want to also filter on the other neighbors, it
ended up being quite generic.

Depends on guacsec#673.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac added a commit to mihaimaruseac/guac that referenced this pull request Apr 6, 2023
@mihaimaruseac
Allow filtering neighbors and paths on GUAC verbs
b52750c 
We can expand it if we want to also filter on the other neighbors, it
ended up being quite generic.

Depends on guacsec#673.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac added a commit to mihaimaruseac/guac that referenced this pull request Apr 6, 2023
@mihaimaruseac
Allow filtering neighbors and paths on GUAC verbs
d5451b7 
We can expand it if we want to also filter on the other neighbors, it
ended up being quite generic.

Depends on guacsec#673.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac added a commit to mihaimaruseac/guac that referenced this pull request Apr 6, 2023
@mihaimaruseac
Allow filtering neighbors and paths on GUAC verbs
8a5ac8b 
We can expand it if we want to also filter on the other neighbors, it
ended up being quite generic.

Depends on guacsec#673.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac added a commit to mihaimaruseac/guac that referenced this pull request Apr 7, 2023
@mihaimaruseac
Allow filtering neighbors and paths on GUAC verbs
88fdfa8 
We can expand it if we want to also filter on the other neighbors, it
ended up being quite generic.

Depends on guacsec#673.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
kodiakhq bot pushed a commit that referenced this pull request Apr 10, 2023
@mihaimaruseac
Allow filtering neighbors and paths on GUAC verbs (#681)
eeebb43 
* Allow filtering neighbors and paths on GUAC verbs

We can expand it if we want to also filter on the other neighbors, it
ended up being quite generic.

Depends on #673.

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

* Allow clients to also filter on edges

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

* Fix certifier

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

* More certifier fixes

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

* No longer precompute slice len as that harms maintenance

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

* Add missing nodes to topological queries

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

* Update generated code

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

* Link noun to edge

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

* Add the other edge orientation

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

* Fix format

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>

---------

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 approved these changes

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihaimaruseac @lumjjb @pxp928
0