8000 Add ingestion mutation for SLSA by mihaimaruseac · Pull Request #553 · guacsec/guac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ingestion mutation for SLSA #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 9, 2023
Merged

Add ingestion mutation for SLSA #553

merged 7 commits into from
Mar 9, 2023

Conversation

mihaimaruseac
Copy link
Collaborator

Need to make sure we use XXXSpec for read-only queries and XXXInput for mutation, since they have different nullability rules and semantics. Took a while to found bugs caused by using the wrong one (after merge conflict resolution).

While here also fix a typo in a file name and remove leftover debug print

Note: pkg/assembler/backends/testing/hasSLSA.go has been rewritten a lot, so github might hide it. That actually contains most of this PR

@mihaimaruseac
Add ingestion mutation
3ffa53a 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Fix typo
325834f 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac mihaimaruseac requested review from lumjjb and pxp928 March 8, 2023 22:52
pxp928
pxp928 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Collaborator
@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihaimaruseac
Propagate mutation to backend
8000
bfafb68 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Dispatch based on subject type
ded28cf 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Ingest SLSA into the test backend
260d2db 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Remove old SLSA ingest which was adding duplicates
1af76ed 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac
Fix format
5e9a56d 
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac mihaimaruseac mentioned this pull request Mar 8, 2023
Merged
@kodiakhq kodiakhq bot merged commit 7b31843 into guacsec:main Mar 9, 2023
@mihaimaruseac mihaimaruseac deleted the gql-3 branch March 9, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 approved these changes

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihaimaruseac @lumjjb @pxp928
0