8000 [FIX] CDX vulnerability parsing and update ENT VEX index by pxp928 · Pull Request #2371 · guacsec/guac · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[FIX] CDX vulnerability parsing and update ENT VEX index #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 18, 2024
Merged

[FIX] CDX vulnerability parsing and update ENT VEX index #2371

merged 7 commits into from
Dec 18, 2024

Conversation

pxp928
Copy link
Collaborator
@pxp928 pxp928 commented Dec 16, 2024

Description of the PR

fixes #2369

Fix CDX vulnerability/VEX ingestion. Removed Status Note and Statement from Ent index as the string can be too long for postgres to index.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@pxp928
fix invalid reference handle, add affected via bom-ref
3b01750 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
remove field statement and status notes from vex index
ba878fd 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
update atlas migration and re-gen code
b1f9754 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 marked this pull request as ready for review December 17, 2024 00:50
@pxp928 pxp928 marked this pull request as draft December 17, 2024 00:51
@pxp928
fix cert vex integration tests for status note and statement
561a1c5 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add new unit test for CDX
36f627d 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add very long status note for integration testing
38e9e05 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
add long statement for vex integration testing
936985c 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 marked this pull request as ready for review December 17, 2024 16:16
@pxp928 pxp928 requested a review from lumjjb December 17, 2024 22:26
8000
@kodiakhq kodiakhq bot merged commit c277250 into main Dec 18, 2024
10 checks passed
@kodiakhq kodiakhq bot deleted the pxp928-issue-2369 branch December 18, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza jeffmendoza approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ingestion/data-quality issue] Error when ingesting SBOM from JFrog Xray
3 participants
@pxp928 @mihaimaruseac @jeffmendoza
0