8000 add spdx-symbol copyright style by jonburdo · Pull Request #350 · fsfe/reuse-tool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add spdx-symbol copyright style #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

jonburdo
Copy link
Contributor
@jonburdo jonburdo commented Apr 25, 2021

The REUSE FAQ page here includes the copyright symbol along with the spdx key as a recommended copyright style, giving the following example:

SPDX-FileCopyrightText: © 2019 John Doe <joe@example.com>

The addheader subcommand's --copyright-style option takes spdx and symbol as options which will provide either the spdx key or the copyright symbol respectively, but doesn't have an option for using both together. This adds spdx-symbol as an option to do this.

Fixed #329

@mxmehl
Copy link
Member
mxmehl commented Apr 27, 2021

Thank you!

LGTM so far, but tests are missing. Could you please add one, e.g. here?

@mxmehl mxmehl added this to the 0.13.0 milestone Apr 27, 2021
@jonburdo
Copy link
Contributor Author
jonburdo commented Apr 27, 2021

Thank you!

LGTM so far, but tests are missing. Could you please add one, e.g. here?

Great! Yes, just added a test. Thanks for the link

@mxmehl
Copy link
Member
mxmehl commented Apr 28, 2021

Perfect, thank you for your contribution!

@mxmehl mxmehl merged commit 4af8dd2 into fsfe:master Apr 28, 2021
@jonburdo jonburdo deleted the add-copyright-style-spdx-symbol branch April 28, 2021 20:02
6D80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add copyright header style for spdx-symbol
2 participants
0