10000 allow different styles of copyright lines by aparcar · Pull Request #248 · fsfe/reuse-tool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

allow different styles of copyright lines #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2020
Merged

allow different styles of copyright lines #248

merged 1 commit into from
Oct 23, 2020

Conversation

aparcar
Copy link
Contributor
@aparcar aparcar commented Aug 12, 2020 •
edited
Loading

adds the arg --copyright-style which accepts spdx, string and
symbol.

  • Add test cases
  • Add docs
  • Ask option to init

I don't this this option is relevant to the init function.

Signed-off-by: Paul Spooren mail@aparcar.org

@aparcar
Copy link
Contributor Author
aparcar commented Aug 12, 2020

This might fix #174

@aparcar aparcar force-pushed the cstyle branch 2 times, most recently from bbd0d64 to eed3ca6 Compare August 12, 2020 00:28
@aparcar aparcar force-pushed the cstyle branch 4 times, most recently from c7898ca to 1b75ff4 Compare September 22, 2020 05:39
@aparcar
Copy link
Contributor Author
aparcar commented Sep 22, 2020

Should be working, please have a look. It doesn't convert the style of existing Copyrights.

mxmehl
mxmehl reviewed Sep 22, 2020
View reviewed changes
@mxmehl
Copy link
Member
mxmehl commented Sep 22, 2020

Nice! WIll test it later, currently my dev setup is kinda broken.

Just one thing about the options: I think we could rename them a bit more intuitively and add one (string with symbol):

    "spdx": "SPDX-FileCopyrightText:",
    "string": "Copyright",
    "string-c": "Copyright (C)",
    "string-symbol": "Copyright ©",
    "symbol": "©",

What do you think?

@aparcar
Copy link
Contributor Author
aparcar commented Sep 22, 2020

Updated

@aparcar
allow different styles of copyright lines
1427651 
adds the arg `--copyright-style` which accepts `spdx`, `string`,
`string-c`, `string-symbol` and `symbol`. All result in different styles
of the Copyright line.

spdx:		SPDX-FileCopyrightText: <year> <statement>
string: 	Copyright <year> <statement>
string-c: 	Copyright (C) <year> <statement>
string-symbol: 	Copyright © <year> <statement>
symbol: 	© <year> <statement>

Signed-off-by: Paul Spooren <mail@aparcar.org>
@mxmehl
Copy link
Member
mxmehl commented Oct 23, 2020

Sorry for the long wait. I tested it, and it works well! Thanks for implementing this feature!

@mxmehl mxmehl merged commit 4d1d941 into fsfe:master Oct 23, 2020
@mxmehl mxmehl mentioned this pull request Oct 23, 2020
Closed
@aparcar aparcar deleted the cstyle branch October 23, 2020 19:29
@kbroch-rivosinc kbroch-rivosinc mentioned this pull request Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmehl mxmehl mxmehl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aparcar @mxmehl
0