8000 Use UTF-8 explicitly when reading files, too. by Flameeyes · Pull Request #242 · fsfe/reuse-tool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use UTF-8 explicitly when reading files, too. #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

Use UTF-8 explicitly when reading files, too. #242

merged 1 commit into from
Aug 31, 2020

Conversation

Flameeyes
Copy link
Contributor

Since the file will be written out in UTF-8, it's a safe bet that they should also be read in UTF-8.

Alternatively, we could support a global setting to override the default encoding, but in 2020 that sounds like a recipe for more headaches than not.

@Flameeyes
Use UTF-8 explicitly when reading files, too.
f110bfd 
Since the file will be written out in UTF-8, it's a safe bet that they should also be read in UTF-8.

Alternatively, we could support a global setting to override the default encoding, but in 2020 that sounds like a recipe for more headaches than not.
@Flameeyes
Copy link
Contributor Author

@carmenbianca ping? :)

@mxmehl
Copy link
Member
mxmehl commented Aug 31, 2020

LGTM, thanks! @carmenbianca please revert if you see a serious issue with this.

@mxmehl mxmehl merged commit 78b1aba into fsfe:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flameeyes @mxmehl
0