8000 Delete also from repair_queue by koba-e964 · Pull Request #263 · frugalos/frugalos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Delete also from repair_queue #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2019
Merged

Delete also from repair_queue #263

merged 1 commit into from
Dec 18, 2019

Conversation

koba-e964
Copy link
Contributor
@koba-e964 koba-e964 commented Dec 6, 2019 •
edited
Loading

Types of changes

Please check one of the following:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New release (merge to both master and develop!)

Description of changes

Behavior

DELETE がジャーナル (?) に記録されている場合や、後から DELETE が発行された場合にリペア対象から DELETE されたオブジェクトを除外する。
前者についてはどのくらいの頻度で起こるかは不明。後者は以下のようにして動作確認できる:

  1. scripts/setup_debug_cluster.sh を実行する
  2. オブジェクトを PUT する
  3. サーバを 1 台止め、そのサーバの dev.lusf を消す
  4. サーバを起動し、repair queue の長さが 1 になるのを待つ
    • frugalos_synchronizer_enqueued_items{type="repair"} - frugalos_synchronizer_dequeued_items{type="repair"} が 1 になれば良い
    1. で PUT したオブジェクトを消す
  6. frugalos_synchronizer_enqueued_items{type="repair"} - frugalos_synchronizer_dequeued_items{type="repair"} が 0 になれば成功

Purpose

Fixes #262.

Checklists

  • Run cargo fmt --all.
  • Run cargo clippy --all --all-targets.

@koba-e964 koba-e964 marked this pull request as ready for review December 9, 2019 09:09
@shinnya shinnya added this to the v0.17.0 milestone Dec 17, 2019
@koba-e964 koba-e964 merged commit 9827035 into develop Dec 18, 2019
@koba-e964 koba-e964 deleted the fix/delete-from-repair_queue branch December 18, 2019 05:36
@shinnya shinnya mentioned this pull request Jan 10, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinnya shinnya shinnya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.17.0
3EF5
Development

Successfully merging this pull request may close these issues.

Repair するときに DELETE したオブジェクトが無駄にリペアされてしまうのを抑制する
2 participants
@koba-e964 @shinnya
0