immutable 参照を mutable 参照にキャストしないようにする #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Please check one of the following:
masteranddevelop!)Description of changes
Behavior
変更なし
Purpose
https://gitter.im/frugalos/development?at=5d974e79b385bf2cc67147d8 のあたりの議論の結果として、 RendezvousNodes::calc_candidates が内部状態を変更しなくなり、&mut self ではなく &self を取るようになった。このため、get_ring で immutable 参照を強引に mutable 参照にする必要がなくなった。
Checklists
cargo fmt --all.cargo clippy --all --all-targets.