8000 Remove StoppableHttpServer by brly · Pull Request #233 · frugalos/frugalos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove StoppableHttpServer #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2019
Merged

Remove StoppableHttpServer #233

merged 3 commits into from
Dec 5, 2019

Conversation

brly
Copy link
Member
@brly brly commented Nov 27, 2019 •
edited
Loading

Types of changes

Please check one of the following:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New release (merge to both master and develop!)

Description of changes

Behavior

  • StoppableHttpServer の削除
    • DaemonRunner が直接 fibers_http_server::Server を所有し DaemonRunner の drop 時に http_server の drop も実行されるようになる
  • 上記に伴い stop_waiting_time パラメータの削除

Purpose

  • 元々 StoppableHttpServer が所有する timer が Async::Ready() を返した後も DaemonRunner が再び poll してしまう問題があり、その対応が必要だった
  • stop_waiting_time 自体はもともと不整合問題の調査向けでもあったが、現在は問題が解消されたと見られるため

Checklists

  • Run cargo fmt --all.
  • Run cargo clippy --all --all-targets.

koba-e964
koba-e964 reviewed Nov 29, 2019
View reviewed changes
Copy link
Contributor
@koba-e964 koba-e964 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits です

shinnya
shinnya reviewed Dec 3, 2019
View reviewed changes
@shinnya
Copy link
Contributor
shinnya commented Dec 3, 2019

nit の部分が修正されれば LGTM です。

@brly @koba-e964
Remove a needless line
0ab48c6 
Co-Authored-By: Hiroki Kobayashi <3303362+koba-e964@users.noreply.github.com>
@shinnya shinnya merged commit 2f0947d into frugalos:develop Dec 5, 2019
@shinnya shinnya added this to the v0.17.0 milestone Dec 17, 2019
@shinnya shinnya mentioned this pull request Jan 10, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinnya shinnya shinnya approved these changes

@koba-e964 koba-e964 koba-e964 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@brly @shinnya @koba-e964
0