Changes the timeout duration of a MDS request to reduce latency #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous timeout duration was decided by exponential back-off, but it occasionaly caused N seconds latency of MDS requests. When the size of a cluster is large, the timeout duration can be lower because MdsClient decides the total number of retries depending on the size.
koba-e964
approved these changes
Dec 18, 2019
brly
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#172 Types of changes
Please check one of the following:
masteranddevelop!)Description of changes
Behavior
MDS へのリクエストで固定時間のタイムアウトを常に使うようになる。
Purpose
クラスタ数が大きい場合に exponential back-off をするとタイムアウト待ち時間が大きくなりすぎ、リクエストにタイムアウトを設定することでレイテンシを改善するという目的が達成できなくなるのを避けること。
Checklists
cargo fmt --all.cargo clippy --all --all-targets.