-
Notifications
You must be signed in to change notification settings - Fork 25
Feature/put many objects #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brly
previously approved these changes
Nov 18, 2019
shinnya
reviewed
Nov 19, 2019
src/server.rs
Outdated
n, | ||
req.url() | ||
); | ||
if count != 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
既存の PUT で巨大なサイズのオブジェクトに対する対応をしている箇所は過去の調査用のためなのでいらないです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3ccd1d1 で直しました
shinnya
reviewed
Nov 19, 2019
shinnya
reviewed
Nov 19, 2019
shinnya
previously approved these changes
Nov 19, 2019
brly
approved these changes
Nov 19, 2019
shinnya
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Please check one of the following:
master
anddevelop
!)Description of changes
Behavior
例えば以下のようにすると、
random-1mib.dat
というファイルのデータがmany-1mib0
からmany-1mib19999
まで PUT される。PUT が完了するまでレスポンスは返ってこない。また、
concurrency
パラメータで、何並列で PUT するかを指定できる。デフォルトは 10 である。Purpose
frugalos に多数のオブジェクトを PUT する機能があると、デバッグ時に便利であるため。
Checklists
cargo fmt --all
.cargo clippy --all --all-targets
.