Handle restoration cases #247
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some tracking of `already_held` on both the dart and rust side, we weren't using it on the rust side. Removed from rust side, but it may be worth considering if it belongs there instead. AlreadyGot wasn't referring to the fact that we received this same share, but rather that we already have received a share from this device. This commit now handles both. Also handle the case of a duplicate plugged in device share.
d0f8eb8 to
f3227f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs a bit more work as it doesn't yet handle the case where the same backup is entered on multiple devices during restoration, it only handles duplicate shares on a plugged in device