-
Notifications
You must be signed in to change notification settings - Fork 1
Add examples on how to auth. #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since comments are not necessary to be changed, LGTM!
|
||
--- | ||
|
||
Using the freva-client python library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-important - One suggestion from a user perspective to make it easier for them to find what they need: What do you think about separating the Python client and the CLI into new .rst files and displaying them as separate items on the left side of the documentation? Currently, when I click on 'Using the REST API endpoints,' I see the RESTful API, Python client, and CLI all grouped together under RestAPI
- The **Python client**: via :py:func``freva_client.authenticate`` | ||
- The **CLI tool**: via ``freva-client auth`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about directly refer to the topic:
- The **Python client**: via :py:func:`freva_client.authenticate` (Or The **Python client**: via `freva_client.authenticate <Using the freva-client python library_>`_ for details)
- The **CLI tool**: via `freva-client auth <Using the command line interface_>`_
|
||
.. literalinclude:: dash_auth_example.py | ||
:language: python | ||
:linenos: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is not necessary and important at all. I would say, instead of having a written auth python example, it could be cool, if we could offer a jupyter notebook as a binder to users could see the rendered html and run the cells by themselves. But again, it's not necessary
This add an example on who to create custom apps with our auth flow.
@felio92 fyi