Linter fixes #354
Merged
Linter fixes #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shusso
reviewed
Jan 11, 2018
| @@ -301,7 +300,7 @@ def test_handle_trade_roi(default_conf, ticker, limit_buy_order, mocker, caplog) | |||
| assert ('freqtrade', logging.DEBUG, 'Executing sell due to ROI ...') in caplog.record_tuples | |||
|
|
|||
|
|
|||
| def test_handle_trade_experimental(default_conf, ticker, limit_buy_order, mocker, caplog): | |||
| def test_handle_trade_experimental(default_conf, ticker, mocker, caplog): | |||
There was a problem hiding this comment.
why is the limit_buy_order removed?
There was a problem hiding this comment.
Because it's not used by the test. I guess someone just copy pasted the test signature.
shusso
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bunch of misc PyLint fixes.