The /status table command was getting slower when we had multiple trades opened #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice PR, I like it. Only one comment, there is no unitest to test the new « refresh » logic in get_ticker(). |
|
Yes sure! |
vertti
reviewed
Jan 3, 2018
freqtrade/exchange/interface.py
Outdated
| """ | ||
| Gets ticker for given pair. | ||
| :param pair: Pair as str, format: BTC_ETC | ||
| :param refresh: Shall we query a new value or a cached value is enought |
glonlas
requested changes
Jan 4, 2018
| @@ -163,7 +168,19 @@ def test_get_ticker(mocker, ticker): | |||
| ticker = get_ticker(pair='BTC_ETH') | |||
| assert ticker['bid'] == 0.00001098 | |||
| assert ticker['ask'] == 0.00001099 | |||
|
|
|||
| # if not caching the result we should get the same ticker | |||
| ticker = get_ticker(pair='BTC_ETH', refresh=False) | |||
There was a problem hiding this comment.
This condition is not tested properly. You should change the ticker before to see that get_ticker() still return the same.
The test could look like that.
def test_get_ticker(mocker, ticker):
api_mock = MagicMock()
api_mock.get_ticker = MagicMock(return_value=ticker())
mocker.patch('freqtrade.exchange._API', api_mock)
ticker = get_ticker(pair='BTC_ETH')
assert ticker['bid'] == 0.00001098
assert ticker['ask'] == 0.00001099
# if not caching the result we should get the same ticker
api_mock.get_ticker = MagicMock(return_value={"bid": 0, "ask": 1})
mocker.patch('freqtrade.exchange._API', api_mock)
ticker = get_ticker(pair='BTC_ETH', refresh=False)
assert ticker['bid'] == 0.00001098
assert ticker['ask'] == 0.00001099
# change the ticker
api_mock.get_ticker = MagicMock(return_value={"bid": 2, "ask": 3})
mocker.patch('freqtrade.exchange._API', api_mock)
ticker = get_ticker(pair='BTC_ETH', refresh=True)
assert ticker['bid'] == 2
assert ticker['ask'] == 3However, when I execute this test, it fails.
22:01 $ pytest freqtrade/tests/exchange/
============================= test session starts ==============================
platform darwin -- Python 3.6.3, pytest-3.3.1, py-1.5.2, pluggy-0.6.0
rootdir: /Users/geraldlonlas/Desktop/dev/freqtrade, inifile:
plugins: mock-1.6.3, cov-2.5.1
collected 21 items
freqtrade/tests/exchange/test_exchange.py ..............F... [ 85%]
freqtrade/tests/exchange/test_exchange_bittrex.py ... [100%]
=================================== FAILURES ===================================
_______________________________ test_get_ticker ________________________________
mocker = <pytest_mock.MockFixture object at 0x1073437b8>
ticker = {'ask': 1, 'bid': 0}
def test_get_ticker(mocker, ticker):
api_mock = MagicMock()
api_mock.get_ticker = MagicMock(return_value=ticker())
mocker.patch('freqtrade.exchange._API', api_mock)
ticker = get_ticker(pair='BTC_ETH')
assert ticker['bid'] == 0.00001098
assert ticker['ask'] == 0.00001099
# if not caching the result we should get the same ticker
api_mock.get_ticker = MagicMock(return_value={"bid": 0, "ask": 1})
ticker = get_ticker(pair='BTC_ETH', refresh=False)
> assert ticker['bid'] == 0.00001098
E assert 0 == 1.098e-05
freqtrade/tests/exchange/test_exchange.py:175: AssertionError
===================== 1 failed, 20 passed in 0.19 seconds ======================This argument enables usage of different backtesting directories. Useful if one wants compare backtesting performance over time.
|
Any update on the Unit tests? |
|
Unitest fixed |
|
Sorry I did merge develop instead of rebasing ... (we do merges @ work ... ) |
--datadir <path> argument
Update ta-lib to 0.4.14
glonlas
approved these changes
Jan 7, 2018
| # if not caching the result we should get the same ticker | ||
| ticker = get_ticker(pair='BTC_ETH', refresh=False) | ||
| print(str(ticker)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each trades opened, the telegram bot was fetching the last bid price making a request towards bittrex.com. This PR allow the use of cached values retrieved in the _process function and fix issue #278.
By opportunity all calls to get the bid prices where replaced in the Bot.