8000 Add offset to "get_trades_for_order" by xmatthias · Pull Request #1211 · freqtrade/freqtrade · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add offset to "get_trades_for_order" #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2018
Merged

Add offset to "get_trades_for_order" #1211

merged 3 commits into from
Sep 27, 2018

Conversation

xmatthias
Copy link
Member
@xmatthias xmatthias commented Sep 15, 2018 •
edited
Loading

Summary

Add 5s offset to cover very slight time-differences (1s should in theory be enough - but better be safe in this case as it doesn't do any harm to get 5s more trades).

Solve the issue: #1185, #1086

Quick changelog

  • add offset to get trade if the exchange-time is slightly behind (or ours is ahead).

@coveralls
Copy link
coveralls commented Sep 15, 2018 •
edited
Loading

Coverage Status

coverage: 94.359% (-4.0%) from 98.408%
when pulling 200dfa7 on fix_no_trades_found
into 4303e86 on develop.

mishaker
mishaker approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member
@mishaker mishaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xmatthias xmatthias merged commit d481895 into develop Sep 27, 2018
@xmatthias xmatthias deleted the fix_no_trades_found branch September 27, 2018 10:40
@xmatthias xmatthias mentioned this pull request Oct 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaotian yaotian yaotian approved these changes

@mishaker mishaker mishaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xmatthias @coveralls @yaotian @mishaker
0