8000 refactor load_markets out of validate_pairs by xmatthias · Pull Request #1204 · freqtrade/freqtrade · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor load_markets out of validate_pairs #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 26, 2018
Merged

refactor load_markets out of validate_pairs #1204

merged 5 commits into from
Sep 26, 2018

Conversation

xmatthias
Copy link
Member

Summary

Refactoring - as promised in #1101 - to remove load_markets from validate_pairs - as it really doesn't belong into this function.

Solve part 1 of the issue: #1196

Quick changelog

  • move load_markets into it's own function.
  • simplify mocking by having (almost) 1 central place to mock exchange

@xmatthias xmatthias mentioned this pull request Sep 11, 2018
Closed
5 tasks
@mishaker
Copy link
Member

Awesome ! will give a review :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 98.411% when pulling c429eae on move_load_markets into 14717b1 on develop.

mishaker
mishaker approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member
@mishaker mishaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find anything to criticize to be honest :) so LGTM 👍

@mishaker
Copy link
Member

@xmatthias anything I can do on this? the PR is pertinent and I didn't find anything odd on it. can we merge u think?

@xmatthias
Copy link
Member Author

yes - forgot about this as it's only refactoring 8000 , not feature or bugfixing ... so absolutely

@xmatthias xmatthias merged commit 766d328 into develop Sep 26, 2018
@xmatthias xmatthias deleted the move_load_markets branch September 26, 2018 04:38
@coveralls
Copy link

Coverage Status

coverage: 94.361% (-4.0%) from 98.408%
when pulling c429eae on move_load_markets
into 14717b1 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishaker mishaker mishaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmatthias @mishaker @coveralls
0