8000 Fix buy_tag not being saved to trade object. by rokups · Pull Request #5399 · freqtrade/freqtrade · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix buy_tag not being saved to trade object. #5399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

Fix buy_tag not being saved to trade object. #5399

merged 1 commit into from
Aug 12, 2021

Conversation

rokups
Copy link
Contributor
@rokups rokups commented Aug 11, 2021

Column is mistakenly excluded because advise_buy() creating this column runs after code detecting presence of buy_tag column.

Is there really a point in trying to exclude this column?

xmatthias
xmatthias reviewed Aug 11, 2021
View reviewed changes
Copy link
Member
@xmatthias xmatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure that the bug you're trying to fix is here, and not in the strategy not assigning the buy_tag correctly?

xmatthias
xmatthias reviewed Aug 11, 2021
View reviewed changes
@rokups
Fix buy_tag not being saved to trade object.
f6267c7 
Column is mistakenly excluded because advise_buy() creating this column runs after code detecting presence of buy_tag column.
@rokups rokups force-pushed the rk/fix-buy-tag-backtest branch from 8ab63a2 to f6267c7 Compare August 11, 2021 12:21
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0007%) to 98.168% when pulling f6267c7 on rokups:rk/fix-buy-tag-backtest into 4e83d5c on freqtrade:develop.

xmatthias
xmatthias approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member
@xmatthias xmatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 💯

LGTM 👍

@xmatthias xmatthias merged commit bdbac37 into freqtrade:develop Aug 12, 2021
@rokups rokups deleted the rk/fix-buy-tag-backtest branch August 29, 2021 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmatthias xmatthias xmatthias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rokups @coveralls @xmatthias
0