8000 Patch progress_callback bug in AniposeCameraCalibrator by aaroncherian · Pull Request #696 · freemocap/freemocap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Patch progress_callback bug in AniposeCameraCalibrator #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 5, 2025
Merged

Patch progress_callback bug in AniposeCameraCalibrator #696

merged 4 commits into from
Jun 5, 2025

Conversation

aaroncherian
Copy link
Collaborator

In the AniposeCameraCalibrator we describe the progress_callback: Callable[[str], None] = None. However, if we run it with the default None, that causes an error. This PR makes a helper function to check whether the progress_callback exists before calling it - so that we can actually use the calibrate_camera_capture_volume function instead of having to create a separate headless_calibration function.

@philipqueen
Copy link
Collaborator

This looks good, but does it work to just pass logger.info or lambda message: logger.info(message) as progress_callback into the calibrator? Or even set those as the default value instead of None?

@aaroncherian
Copy link
Collaborator Author

This looks good, but does it work to just pass logger.info or lambda message: logger.info(message) as progress_callback into the calibrator? Or even set those as the default value instead of None?

Gotcha - made the changes to have it be a default None lambda instead.

philipqueen
philipqueen approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator
@philipqueen philipqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jonmatthis jonmatthis merged commit ee037fe into main Jun 5, 2025
3 checks passed
@jonmatthis jonmatthis deleted the aaron/patch_optional_progress_callback branch June 5, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmatthis jonmatthis jonmatthis approved these changes

@philipqueen philipqueen philipqueen approved these changes

@endurance endurance Awaiting requested review from endurance endurance is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaroncherian @philipqueen @jonmatthis
0