Create coutense.ruleset #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Couto Misto, a former micro-state which was located in Spain
cazfi
added a commit
that referenced
this pull request
Dec 16, 2023
It was returning size of the buffer it was given, at max. Now it correctly returns the size that would be needed for the generated string. Astring buffer was not grown because of this, as it seemed like the partial write that fit the old small buffer was succesful. See RM #58 Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
cazfi
added a commit
that referenced
this pull request
Dec 16, 2023
It was returning size of the buffer it was given, at max. Now it correctly returns the size that would be needed for the generated string. Astring buffer was not grown because of this, as it seemed like the partial write that fit the old small buffer was succesful. See RM #58 Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
cazfi
added a commit
that referenced
this pull request
Dec 16, 2023
It was returning size of the buffer it was given, at max. Now it correctly returns the size that would be needed for the generated string. Astring buffer was not grown because of this, as it seemed like the partial write that fit the old small buffer was succesful. See RM #58 Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
cazfi
added a commit
that referenced
this pull request
Dec 16, 2023
It was returning size of the buffer it was given, at max. Now it correctly returns the size that would be needed for the generated string. Astring buffer was not grown because of this, as it seemed like the partial write that fit the old small buffer was succesful. See RM #58 Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
cazfi
added a commit
that referenced
this pull request
Dec 16, 2023
It was returning size of the buffer it was given, at max. Now it correctly returns the size that would be needed for the generated string. Astring buffer was not grown because of this, as it seemed like the partial write that fit the old small buffer was succesful. See RM #58 Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
karim20230
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Couto Misto, a former micro-state which was located in Spain.
I don't think there will be any nations Couto Misto conflicts with, as it coexisted with all it's neighbours.
@cazfi Sorry for the late reply I haven't had time in the past months to work on Freeciv. Yes I would be interested in maintaining nations. I study history 1-2 hours per day so it will be interesting. I will have plenty of more time from now on.
Ticket to handle this: https://osdn.net/projects/freeciv/ticket/48957