Buffer packets with sequence numbers in GTP header. #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-ywliu
reviewed
Jan 13, 2025
src/gtpu/encap.c
Outdated
| @@ -417,7 +419,8 @@ static int netlink_send(struct pdr *pdr, struct far *far, struct sk_buff *skb_in | |||
| nla_total_size_64bit(8) + | |||
There was a problem hiding this comment.
nla_total_size_64bit(8) + // SEID
nla_total_size(2) + // PDR ID
nla_total_size(2) + // Action
nla_total_size(2) + // Sequence Num
nla_total_size(skb_in->len), // Buff Pkt Size
773e393 to
f3e5855
Compare
tim-ywliu
reviewed
Jan 13, 2025
src/gtpu/encap.c
Outdated
| @@ -468,6 +471,12 @@ static int netlink_send(struct pdr *pdr, struct far *far, struct sk_buff *skb_in | |||
| } | |||
| skb_copy_bits(skb_in, 0, nla_data(attr), skb_in->len); | |||
|
|
|||
| err = nla_put_u16(skb, GTP5G_BUFFER_SEQ_NUMBER, far->seq_number); | |||
There was a problem hiding this comment.
move between GTP5G_BUFFER_ACTION and GTP5G_BUFFER_PACKET
52ec048 to
36acd80
Compare
tim-ywliu
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new attribute sequence numbers for buffered packets.