Accept a special value "null" for LOG_DESTINATION #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parses a new value `"null"` as a `LogDestination`. On non-Windows systems, it'll be equivalent to `"@/dev/null"`. On Windows systems, `"@\\.\NUL"` (an explicitly-namespaced form for the `NUL` device[^1]). Closes #50. I chose not to investigate the open question about whether or not `LOG_DESTINATION=NUL` would already Just Work. I decided it didn't matter, for two reasons: 1. While it's likely "specifying `NUL`" may conceptually work, it's very possible you still need to practically use `LOG_DESTINATION=\\.\NUL` to do it. That would not be very discoverable and the escaping required would be quite error-prone, making the `null` sugar valuable. 2. Mixed-OS teams attempting to have null as a default in (e.g.) `.env` can't do so today. Without this sugar, such teams would have to concretely pick `/dev/null` or `NUL`. Together, this seemed like enough to warrant the small bit of alias complexity. [^1]: https://stackoverflow.com/a/58177337
chris-martin
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses a new value
"null"as aLogDestination. On non-Windowssystems, it'll be equivalent to
"@/dev/null". On Windows systems,"@\\.\NUL"(an explicitly-namespaced form for theNULdevice1).Closes #50.
I chose not to investigate the open question about whether or not
LOG_DESTINATION=NULwould already Just Work. I decided it didn'tmatter, for two reasons:
While it's likely "specifying
NUL" may conceptually work, it's verypossible you still need to practically use
LOG_DESTINATION=\\.\NULto do it.
That would not be very discoverable and the escaping required would
be quite error-prone, making the
nullsugar valuable.Mixed-OS teams attempting to have null as a default in (e.g.)
.envcan't do so today.
Without this sugar, such teams would have to concretely pick
/dev/nullorNUL.Together, this seemed like enough to warrant the small bit of alias
complexity.
Footnotes
https://stackoverflow.com/a/58177337 ↩