8000 Add withLoggerEnv by chris-martin · Pull Request #45 · freckle/blammo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add withLoggerEnv #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Add withLoggerEnv #45

merged 5 commits into from
Jun 3, 2024

Conversation

chris-martin
Copy link
Contributor

No description provided.

@chris-martin chris-martin requested a review from pbrisbin June 3, 2024 18:52
@chris-martin chris-martin changed the title Add MonadUnliftIO (WithLogger env m) Add withLoggerEnv, instance MonadUnliftIO (WithLogger env m) Jun 3, 2024
@chris-martin chris-martin requested a review from pbrisbin June 3, 2024 19:08
@chris-martin
Copy link
Contributor Author

So actually, I can just use AppT. Going to back off on the instances for WithLogger.

runWithLogger appLogger DB.makePostgresPool
runAppT DB.makePostgresPool appLogger

@pbrisbin
Copy link
Member
pbrisbin commented Jun 3, 2024
runAppT DB.makePostgresPool appLogger

🤯

@chris-martin
Copy link
Contributor Author

🤯

Ain't nothing in the rulebook says loggers can't be apps.

@chris-martin chris-martin changed the title Add withLoggerEnv, instance MonadUnliftIO (WithLogger env m) Add withLoggerEnv Jun 3, 2024
@chris-martin chris-martin enabled auto-merge (squash) June 3, 2024 19:31
@chris-martin chris-martin disabled auto-merge June 3, 2024 19:40
@chris-martin chris-martin merged commit b2e52ec into main Jun 3, 2024
9 checks passed
@chris-martin chris-martin deleted the chris/unliftio branch June 3, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0