8000 feat: Branch switcher in bench UI by NagariaHussain · Pull Request #127 · frappe/press · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Branch switcher in bench UI #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Jun 25, 2021
Merged

feat: Branch switcher in bench UI #127

merged 42 commits into from
Jun 25, 2021

Conversation

NagariaHussain
Copy link
Collaborator
@NagariaHussain NagariaHussain commented Jun 9, 2021 •
edited
Loading

Branch-switcher

netchampfaris
netchampfaris requested changes Jun 9, 2021
View reviewed changes
Copy link
Contributor
@netchampfaris netchampfaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change branch logic is not trivial, it should be moved to the ReleaseGroup controller.

Ideal API:

rg = frappe.get_doc('Release Group', name)
rg.change_app_branch(app, branch)

@NagariaHussain
refactor: Arg names and throw on already on to_branch
7fc40e7
@NagariaHussain
perf: Limit App Source query results to 1
8d917f9
@NagariaHussain
refactor: Move branch change logic to RG controller
8c46d90
10000 @NagariaHussain
fix: Type annotation
cc85f5a
@NagariaHussain
test: change_branch method raises
a3e86f4
@NagariaHussain
test: Branch change, app source already exists
cb66632
@NagariaHussain
test: Branch change, new app source to be created
12abb9b
@NagariaHussain
refactor: Add type annotations
afc4f26
@NagariaHussain
feat: Branch List API
81eddb6
@NagariaHussain
feat: Fetch branch list in front-end
6e28afb
@NagariaHussain
refactor: Rename get app source method
348723c
@NagariaHussain
feat: Branch change flag in deploy information API
1f219bc
@NagariaHussain
refactor: Change dropdown to select
b31f0d4
@NagariaHussain
refactor: Branch List structure
27fdb94
@NagariaHussain
feat: Change Branch button
b1ecd37
@NagariaHussain
fix: Copy github installation id to new source
b14bdb3
@NagariaHussain
feat: Notify user
b1dcf28
@NagariaHussain
chore: Return old branch name from API
3abdd15
@NagariaHussain
feat(ux): Branch change in update dialog
954acf9
@NagariaHussain
fix: Missing doc comment
3b65f77
@NagariaHussain
refactor: Reload window after change
54cd82d
@NagariaHussain
Merge branch 'master' into feat-branch-switcher
119428d
netchampfaris
netchampfaris requested changes Jun 23, 2021
View reviewed changes
netchampfaris
netchampfaris previously approved these changes Jun 24, 2021
View reviewed changes
@NagariaHussain NagariaHussain merged commit 5c30ce7 into frappe:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. 66D4 Already have an account? Sign in to comment
Reviewers

@balamurali27 balamurali27 balamurali27 approved these changes

@netchampfaris netchampfaris netchampfaris left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NagariaHussain @netchampfaris @balamurali27
0