perf: Faster "show title in link field" on list view #25597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally, this query should be converted to "Top N" variant and just pick first 20 records, join only them with other table and send data back. Currently we always group by `name` in list view. This makes "show title in link field" join queries insanely slow as it first queries entire table and then applies limit.
|
TODO:
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
Ideally, this query should be converted to "Top N" variant and just pick first 20 records, join only them with other table and send data back. Currently we always group by `name` in list view. This makes "show title in link field" join queries insanely slow as it first queries entire table and then applies limit. (cherry picked from commit bad3b9e)
mergify bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
Ideally, this query should be converted to "Top N" variant and just pick first 20 records, join only them with other table and send data back. Currently we always group by `name` in list view. This makes "show title in link field" join queries insanely slow as it first queries entire table and then applies limit. (cherry picked from commit bad3b9e)
ankush
added a commit
that referenced
this pull request
Mar 23, 2024
Ideally, this query should be converted to "Top N" variant and just pick first 20 records, join only them with other table and send data back. Currently we always group by `name` in list view. This makes "show title in link field" join queries insanely slow as it first queries entire table and then applies limit. (cherry picked from commit bad3b9e) Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush
added a commit
that referenced
this pull request
Mar 23, 2024
Ideally, this query should be converted to "Top N" variant and just pick first 20 records, join only them with other table and send data back. Currently we always group by `name` in list view. This makes "show title in link field" join queries insanely slow as it first queries entire table and then applies limit. (cherry picked from commit bad3b9e) Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
# [14.69.0](v14.68.2...v14.69.0) (2024-03-27) ### Bug Fixes * allow page length 2500 ([#25062](#25062)) ([d40a169](d40a169)) * **Contact form:** make email translatable ([1a794df](1a794df)) * **Contact form:** make title and options translatable ([6d731fa](6d731fa)) * **Contact form:** translate internal notification to system language ([2b2cf83](2b2cf83)) * DB Query distinct handling with full table name ([#25594](#25594)) ([#25596](#25596)) ([d201326](d201326)) * diff after converting to html to text ([#25582](#25582)) ([#25583](#25583)) ([68d6947](68d6947)) * don't parse CSV params for Excel ([87c6fc6](87c6fc6)) * duplicate translation of field labels ([471ad26](471ad26)) * fieldname referenced before assignment ([95a0db8](95a0db8)) * **lint:** v14 doesn't have typed doctype classes, so this was never needed ([#25578](#25578)) ([e343a32](e343a32)) * Mark totals row correctly for print ([#25629](#25629)) ([#25630](#25630)) ([a902f6d](a902f6d)) * only add title field in search if it exists ([#25634](#25634)) ([#25635](#25635)) ([446c4d6](446c4d6)) * pop from form_params ([377b35c](377b35c)) * ruff fixes ([8ecc7d9](8ecc7d9)) * test reportview ([bb5c3a1](bb5c3a1)) ### Features * add csv preview ([d89a126](d89a126)) * add test for exporting reportview as CSV ([4eb31e0](4eb31e0)) * add translation context ([88cfe4b](88cfe4b)) * allow setting a custom rate limit for `login via email link` feature ([b7a1da5](b7a1da5)) * connect to redis sentinel for redis queue (backport [#25506](#25506)) ([#25556](#25556)) ([a9ee773](a9ee773)) * CSV params for query report ([7493c4e](7493c4e)) * CSV params for report view ([9f14d65](9f14d65)) * german translations for export dialog ([eab535d](eab535d)) * hide csv settings in collapsible section ([efb70be](efb70be)) * preview real data ([91b20b8](91b20b8)) ### Performance Improvements * Faster "show title in link field" on list view ([#25597](#25597)) ([#25621](#25621)) ([7df36f6](7df36f6)) * remove useless sorting on docstatus ([#25571](#25571)) ([#25590](#25590)) ([5e65cc9](5e65cc9)) ### Reverts * Revert "fix: escape text types before setting disp area (#25520) (#25522)" (#25604) ([0bf0cb8](0bf0cb8)), closes [#25520](#25520) [#25522](#25522) [#25604](#25604)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
# [15.19.0](v15.18.2...v15.19.0) (2024-03-27) ### Bug Fixes * add missing arg while invoking _download_multi_pdf ([f82ed9f](f82ed9f)) * allow page length 2500 ([#25062](#25062)) ([75b1f6c](75b1f6c)) * **Contact form:** make email translatable ([800cfee](800cfee)) * **Contact form:** make title and options translatable ([b1dbd79](b1dbd79)) * **Contact form:** translate internal notification to system language ([f67e5f1](f67e5f1)) * DB Query distinct handling with full table name ([#25594](#25594)) ([4fe0498](4fe0498)) * diff after converting to html to text ([#25582](#25582)) ([#25584](#25584)) ([bd7372d](bd7372d)) * Mark totals row correctly for print ([#25629](#25629)) ([#25631](#25631)) ([725018f](725018f)) * only add title field in search if it exists ([#25634](#25634)) ([#25636](#25636)) ([b2260c1](b2260c1)) * redirect after login, todo filters (backport [#25521](#25521)) ([#25561](#25561)) ([d9f9aa4](d9f9aa4)), closes [#25455](#25455) [#25455](#25455) * respect `null` as number value ([#25639](#25639)) ([5b64ac9](5b64ac9)) * set list row height to 40px ([#25619](#25619)) ([#25625](#25625)) ([af406f9](af406f9)) * **test:** update RQ serialization test ([c764282](c764282)) * Translate form and workflow builder (backport [#25482](#25482)) ([#25547](#25547)) ([01f469f](01f469f)) * **webhook:** `r` is referenced here before its initialized ([a60bb4e](a60bb4e)), closes [#21064](#21064) * **workspace:** Don't allow Welcome as default workspace ([819a24c](819a24c)) ### Features * allow setting a custom rate limit for `login via email link` feature ([c7af627](c7af627)) * connect to redis sentinel for redis queue ([#25557](#25557)) ([82a33c3](82a33c3)) * drop sentry's RQ integration ([1eab176](1eab176)) * **workspace:** Allow user to choose a default workspace ([bfa1a83](bfa1a83)) ### Performance Improvements * Faster "show title in link field" on list view ([#25597](#25597)) ([#25622](#25622)) ([f62a30c](f62a30c)) * remove useless sorting on docstatus ([#25571](#25571)) ([#25591](#25591)) ([5e5853e](5e5853e)) ### Reverts * Revert "fix: escape text types before setting disp area (#25520) (#25523)" (#25603) ([bbf55df](bbf55df)), closes [#25520](#25520) [#25523](#25523) [#25603](#25603)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, this query should be converted to "Top N" variant and just pick
first 20 records, join only them with other table and send data back.
Currently we always group by
namein list view. This makes "show titlein link field" join queries insanely slow as it first queries entire
table and then applies limit.