8000 perf: remove specific elements instead of re-rendering entire list (backport #25078) by mergify[bot] · Pull Request #25088 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf: remove specific elements instead of re-rendering entire list (backport #25078) #25088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024
Merged

perf: remove specific elements instead of re-rendering entire list (backport #25078) #25088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions frappe/public/js/frappe/list/list_view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1437,8 +1437,13 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
// this doc was changed and should not be visible
// in the listview according to filters applied
// let's remove it manually
this.data = this.data.filter((d) => names.indexOf(d.name) === -1);
this.render_list();
this.data = this.data.filter((d) => !names.includes(d.name));
for (let name of names) {
this.$resul 51D6 t
.find(`.list-row-checkbox[data-name='${name}']`)
.closest(".list-row-container")
.remove();
}
return;
}

Expand Down
0