8000 fix: keep order in `get_values_from_single` by barredterra · Pull Request #24907 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: keep order in get_values_from_single #24907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2024
Merged

fix: keep order in get_values_from_single #24907

merged 2 commits into from
Feb 19, 2024

Conversation

barredterra
Copy link
Collaborator
@barredterra barredterra commented Feb 16, 2024 •
edited
Loading

Before:

In [1]: frappe.db.get_values_from_single(["language", "date_format"], None, "System Settings")
Out[1]: [['dd-mm-yyyy', 'de']]

In [2]: frappe.db.get_values_from_single(["does_not_exist", "date_format"], None, "System Settings")
Out[2]: [['dd-mm-yyyy']]

After:

In [1]: frappe.db.get_values_from_single(["language", "date_format"], None, "System Settings")
Out[1]: [['de', 'dd-mm-yyyy']]

In [2]: frappe.db.get_values_from_single(["does_not_exist", "date_format"], None, "System Settings")
Out[2]: [[None, 'dd-mm-yyyy']]

@barredterra barredterra requested review from a team and ankush and removed request for a team February 16, 2024 23:20
@ankush ankush added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels Feb 18, 2024
@ankush ankush enabled auto-merge (squash) February 19, 2024 05:23
@ankush ankush merged commit 68eb2d9 into frappe:develop Feb 19, 2024
mergify bot pushed a commit that referenced this pull request Feb 19, 2024
@barredterra @ankush @mergify
fix: keep order in get_values_from_single (#24907)
385727e 
* fix: keep order in `get_values_from_single`

* fix: add test for destructuring

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 68eb2d9)
@mergify mergify bot mentioned this pull request Feb 19, 2024
Merged
mergify bot pushed a commit that referenced this pull request Feb 19, 2024
@barredterra @ankush @mergify
fix: keep order in get_values_from_single (#24907)
fae2948 
* fix: keep order in `get_values_from_single`

* fix: add test for destructuring

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 68eb2d9)
@mergify mergify bot mentioned this pull request Feb 19, 2024
Merged
ankush pushed a commit that referenced this pull request Feb 19, 2024
@mergify @barredterra
fix: keep order in get_values_from_single (#24907) (#24924)
d8f663b 
* fix: keep order in `get_values_from_single`

* fix: add test for destructuring

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 68eb2d9)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
ankush pushed a commit that referenced this pull request Feb 19, 2024
@mergify @barredterra
fix: keep order in get_values_from_single (#24907) (#24923)
3347144 
* fix: keep order in `get_values_from_single`

* fix: add test for destructuring

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 68eb2d9)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
@barredterra barredterra deleted the single-value-order branch February 19, 2024 09:04
frappe-pr-bot pushed a commit that referenced this pull request Feb 20, 2024
@frappe-bot
chore(release): Bumped to Version 14.66.2
b26f55c 
## [14.66.2](v14.66.1...v14.66.2) (2024-02-20)

### Bug Fixes

* **calendar:** Replace route in load_last_view ([#24894](#24894)) ([#24927](#24927)) ([fa184d6](fa184d6))
* ensure has_value_changed works for Datetime, Date and Time fields (backport [#24919](#24919)) ([#24921](#24921)) ([8087a7a](8087a7a))
* handle bad cron expressions (backport [#24938](#24938)) ([#24941](#24941)) ([4efcdb5](4efcdb5))
* ignore and gracefully handle img optimization failure ([b112333](b112333))
* invite contact as user ([136ac70](136ac70))
* keep order in `get_values_from_single` ([#24907](#24907)) ([#24923](#24923)) ([3347144](3347144))
* lower socket timeout for validating email domain ([#24915](#24915)) ([#24917](#24917)) ([427e681](427e681))
* **page:** Catch LocalStorage quota exception ([#24885](#24885)) ([#24930](#24930)) ([3a36f7d](3a36f7d))
* send_workflow_action_email ([#24929](#24929)) ([#24933](#24933)) ([5f29c83](5f29c83))
* set same cookie expiry on client side (backport [#24560](#24560)) ([#24567](#24567)) ([744b363](744b363))
* use communication date in timeline ([0632cb3](0632cb3))
* **weblist:** Fix "More" button not working ([#24893](#24893)) ([#24925](#24925)) ([1715638](1715638))
frappe-pr-bot pushed a commit that referenced this pull request Feb 20, 2024
@frappe-bot
chore(release): Bumped to Version 15.15.0
aab8947 
# [15.15.0](v15.14.1...v15.15.0) (2024-02-20)

### Bug Fixes

* **calendar:** Replace route in load_last_view ([#24894](#24894)) ([#24928](#24928)) ([2557384](2557384))
* ensure has_value_changed works for Datetime, Date and Time fields (backport [#24919](#24919)) ([#24922](#24922)) ([87e7702](87e7702))
* handle bad cron expressions (backport [#24938](#24938)) ([#24942](#24942)) ([18512d6](18512d6))
* invite contact as user ([4e308e4](4e308e4))
* keep order in `get_values_from_single` ([#24907](#24907)) ([#24924](#24924)) ([d8f663b](d8f663b))
* lower socket timeout for validating email domain ([#24915](#24915)) ([#24918](#24918)) ([796c7c0](796c7c0))
* **page:** Catch LocalStorage quota exception ([#24885](#24885)) ([#24931](#24931)) ([cb3a435](cb3a435))
* send_workflow_action_email ([#24929](#24929)) ([#24934](#24934)) ([7e9eec0](7e9eec0))
* use communication date in timeline ([8bebcb6](8bebcb6))
* **weblist:** Fix "More" button not working ([#24893](#24893)) ([#24926](#24926)) ([4732928](4732928))

### Features

* pass doctype as context when translating label (backport [#24903](#24903)) ([#24916](#24916)) ([6cdc0a7](6cdc0a7))
* Queue selection for webhooks ([#24876](#24876)) ([#24932](#24932)) ([bd2b90c](bd2b90c))

### Performance Improvements

* defer imports during CLI (backport [#24945](#24945)) ([#24946](#24946)) ([a23a758](a23a758))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush ankush approved these changes

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barredterra @ankush
0