fix: use communication date in timeline #24884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we used the database creation date, which coincidentally corresponds to the real communication date in many cases.
akhilnarang
approved these changes
Feb 19, 2024
This was referenced Feb 19, 2024
akhilnarang
added a commit
that referenced
this pull request
Feb 19, 2024
…-24884 fix: use communication date in timeline (backport #24884)
akhilnarang
added a commit
that referenced
this pull request
Feb 19, 2024
…-24884 fix: use communication date in timeline (backport #24884)
ankush
reviewed
Mar 11, 2024
| @@ -23,7 +23,7 @@ | |||
| {% } %} | |||
|
|
|||
| <div class="text-muted"> | |||
| {{ comment_when(doc.creation) }} | |||
| {{ comment_when(doc.communication_date) }} | |||
There was a problem hiding this comment.
Comments and other timeline items don't use this, need to still use creation as fallback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we used the database creation date, which may coincidentally corresponds to the real communication date (email sent and synced today) but not always (email sent three years ago, synced to the database today).
As per the few thousand communications in our system, the communication date is always available. Since it's more accurate, we should use it.
Before
(The communication record was apparently created two weeks ago, but the email is three years old. Displaying the creation date is misleading.)
After