refactor: Reset password flow #24857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd82e8b to
34f6761
Compare
Experiment 🤷
- Hash one time reset tokens instead of storing them as is - Up the perm level - Use better source of randomness for generating token - minor code cleanup here and there
34f6761 to
38565a8
Compare
- password managers use paste, added that event to trigger our code - if no password policy then skip. Way too much needless business logic in HTML here.
cdfa46a to
78264a7
Compare
|
Did you remove the tour definitions on purpose? |
|
Tested the functionality - LGTM |
|
Yeah tour removal is on purpose. Kinda broken after Espresso rework and also no one completes them based on telemetry data. We are working on other ways to improve onboarding. |
This was referenced Feb 11, 2024
ankush
added a commit
that referenced
this pull request
Feb 19, 2024
* chore: remove default UI tours Experiment 🤷 (cherry picked from commit 74071c1) * refactor: Reset password flow - Hash one time reset tokens instead of storing them as is - Up the perm level - Use better source of randomness for generating token - minor code cleanup here and there (cherry picked from commit 4c925e0) # Conflicts: # frappe/core/doctype/user/user.json # frappe/core/doctype/user/user.py # frappe/patches.txt # frappe/tests/test_utils.py * test: redo reset password tests (cherry picked from commit 38565a8) # Conflicts: # frappe/core/doctype/user/test_user.py * fix(UX): usability of reset password page - password managers use paste, added that event to trigger our code - if no password policy then skip. Way too much needless business logic in HTML here. (cherry picked from commit 78264a7) * chore: conflicts * debug --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush
added a commit
that referenced
this pull request
Feb 19, 2024
* chore: remove default UI tours Experiment 🤷 (cherry picked from commit 74071c1) * refactor: Reset password flow - Hash one time reset tokens instead of storing them as is - Up the perm level - Use better source of randomness for generating token - minor code cleanup here and there (cherry picked from commit 4c925e0) # Conflicts: # frappe/core/doctype/user/user.json # frappe/core/doctype/user/user.py # frappe/patches.txt # frappe/tests/test_utils.py * test: redo reset password tests (cherry picked from commit 38565a8) # Conflicts: # frappe/core/doctype/user/test_user.py # frappe/tests/utils.py * fix(UX): usability of reset password page - password managers use paste, added that event to trigger our code - if no password policy then skip. Way too much needless business logic in HTML here. (cherry picked from commit 78264a7) * chore: conflicts --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
6F35
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: