8000 fix: Use `TEXT` type for Webhook URLs to support large URLs (backport #24761) by mergify[bot] · Pull Request #24763 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Use TEXT type for Webhook URLs to support large URLs (backport #24761) #24763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: Use TEXT type for Webhook URLs to support large URLs (backport #24761) #24763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frappe/integrations/doctype/webhook/webhook.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
},
{
"fieldname": "request_url",
"fieldtype": "Data",
"fieldtype": "Small Text",
"in_list_view": 1,
"label": "Request URL",
"reqd": 1
Expand Down Expand Up @@ -221,7 +221,7 @@
"link_fieldname": "webhook"
}
],
"modified": "2023-06-16 10:21:00.971833",
"modified": "2024-02-05 17:49:50.203001",
"modified_by": "Administrator",
"module": "Integrations",
"name": "Webhook",
Expand Down
3 changes: 2 additions & 1 deletion frappe/integrations/doctype/webhook/webhook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class Webhook(Document):
preview_request_body: DF.Code | None
request_method: DF.Literal["POST", "PUT", "DELETE"]
request_structure: DF.Literal["", "Form URL-Encoded", "JSON"]
request_url: DF.Data
request_url: DF.SmallText
timeout: DF.Int
webhook_data: DF.Table[WebhookData]
webhook_docevent: DF.Literal[
Expand All @@ -56,6 +56,7 @@ class Webhook(Document):
webhook_json: DF.Code | None
webhook_secret: DF.Password | None
# end: auto-generated types

def validate(self):
self.validate_docevent()
self.validate_condition()
Expand Down
0