8000 fix(js): Handle hidden virtual fields by cogk · Pull Request #24405 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(js): Handle hidden virtual fields #24405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

cogk
Copy link
Contributor
@cogk cogk commented Jan 16, 2024

Maybe closes #23541, not well tested.

@cogk cogk requested review from a team and surajshetty3416 and removed request for a team January 16, 2024 16:17
Copy link
codecov bot commented Jan 16, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c17f014) 61.17% compared to head (5d2f082) 61.26%.
Report is 19 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24405      +/-   ##
===========================================
+ Coverage    61.17%   61.26%   +0.08%     
===========================================
  Files          786      786              
  Lines        75821    75051     -770     
  Branches      6423     6423              
===========================================
- Hits         46385    45981     -404     
+ Misses       25137    24774     -363     
+ Partials      4299     4296       -3     
Flag Coverage Δ
server-ui 27.12% <69.69%> (+0.01%) ⬆️
ui-tests 48.83% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush merged commit 766a7ef into frappe:develop Jan 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
@ankush ankush added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels Feb 2, 2024
@ankush
Copy link
Member
ankush commented Feb 2, 2024

@cogk #24693

use cases tested:

  1. virtual fields should always be read only - if there's data or not
  2. virtual fields when there's no data should be hidden like rest of them.
  3. Same behaviour in child tables.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't hide Virtual Fields
2 participants
0