fix(minor): add optional chaining for this.$input #24323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- before trying to toggleClass on this.$input check if it exists
- before trying to toggleClass on th 8000 is.$input check if it exists
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24323 +/- ##
===========================================
- Coverage 62.11% 62.06% -0.05%
===========================================
Files 786 786
Lines 74944 74944
Branches 6420 6420
===========================================
- Hits 46549 46512 -37
- Misses 24742 24762 +20
- Partials 3653 3670 +17
Flags with carried forward coverage won't be shown. Click here to find out more. |
barredterra
approved these changes
Jan 14, 2024
This was referenced Jan 14, 2024
ankush
reviewed
Jan 15, 2024
| @@ -217,7 +217,7 @@ frappe.ui.form.ControlInput = class ControlInput extends frappe.ui.form.Control | |||
| let invalid = !!this.df.invalid; | |||
| if (this.grid) { | |||
| this.$wrapper.parents(".grid-static-col").toggleClass("invalid", invalid); | |||
| this.$input.toggleClass("invalid", invalid); | |||
| this.$input?.toggleClass("invalid", invalid); | |||
There was a problem hiding this comment.
Umm, why this happens? All inputs are supposed to have inputs?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.