fix: don't update docstatus (backport #24216) #24221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't make sense. Updating docstatus without resaving document is a bad idea. Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com> (cherry picked from commit 02031fc) # Conflicts: # frappe/workflow/doctype/workflow/workflow.py
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
# [15.9.0](v15.8.1...v15.9.0) (2024-01-10) ### Bug Fixes * added precision field in webform field ([3876ba2](3876ba2)) * added validation if upload is clicked without uploading file ([ba2ce30](ba2ce30)) * Allowed standard fields in data export ( creation, owner) (backport [#24187](#24187)) ([#24191](#24191)) ([5b66da4](5b66da4)) * broken `dynamic_link` to `link` formatting in query report (backport [#24054](#24054)) ([#24088](#24088)) ([4a9eae9](4a9eae9)) * Broken IMAP account disabling logic (backport [#24118](#24118)) ([#24131](#24131)) ([7669a7e](7669a7e)) * **communication:** don't change email case ([f91cff9](f91cff9)) * copy content on reply ([5135a13](5135a13)) * Correct logic for can_cancel ([#24196](#24196)) ([#24201](#24201)) ([94312f6](94312f6)) * delete existing children first to avoid `UniqueValidationError` ([#24140](#24140)) ([f00da85](f00da85)) * don't update docstatus (backport [#24216](#24216)) ([#24221](#24221)) ([b95f7c3](b95f7c3)) * **DX:** return email queue doc ([#23495](#23495)) ([#24174](#24174)) ([f25e42f](f25e42f)) * extract the frappe version from backup header directly ([4d2cf23](4d2cf23)) * get precision data while getting fields ([4cb65f0](4cb65f0)) * Handle empty value of datetime control ([cc3997d](cc3997d)) * include Web Form Field in core_doctypes ([785416a](785416a)) * **minor:** drop icon column, unsupported, fixes [#23826](#23826) ([a18c061](a18c061)) * **minor:** show footer on login via Website Settings, fixes [#24153](#24153) ([8a0b5c7](8a0b5c7)) * **minor:** Unpublish article when category is unpublished [#15361](#15361) ([c2c8323](c2c8323)) * mobile issue with form pop up ([#24125](#24125)) ([#24151](#24151)) ([de30760](de30760)) * notification.py should ignore permissions on fetching on mobile_no receiver list ([6f5535b](6f5535b)) * number card only gives integer ([#24047](#24047)) ([#24138](#24138)) ([16f9907](16f9907)) * **OTP:** Autofocus OTP input, fix placeholder ([#24203](#24203)) ([#24205](#24205)) ([458f3fc](458f3fc)) * **recorder:** Normalize `IN` in SQL queries ([#24132](#24132)) ([#24134](#24134)) ([9dc4d8f](9dc4d8f)) * **router:** Don't capture clicks on links with target attr ([#24110](#24110)) ([#24135](#24135)) ([b80de74](b80de74)) * Skip no-value fields for rename ([#24163](#24163)) ([#24164](#24164)) ([dfa2ffd](dfa2ffd)) * **style:** set min height correctly ([c774787](c774787)) * **test_recorder:** get the correct request ([#24143](#24143)) ([#24149](#24149)) ([9fa7e9f](9fa7e9f)) * use correct parent field in rebuild_tree() ([#24107](#24107)) ([#24121](#24121)) ([f12f9db](f12f9db)) * **Web Form:** make button label translatable ([#24122](#24122)) ([14ee9c8](14ee9c8)) * webhook error logging fails ([#24172](#24172)) ([#24183](#24183)) ([6cd7eba](6cd7eba)) ### Features * support background jobs in recorder ([1eb3a56](1eb3a56)) ### Performance Improvements * Update roles affected by role profile in background ([#24104](#24104)) ([840f059](840f059))
|
🎉 This PR is included in version 15.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #24216 done by Mergify.
Cherry-pick of 02031fc has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com