8000 feat: Skip locked rows while selecting by ankush · Pull Request #24298 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Skip locked rows while selecting #24298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Conversation

ankush
Copy link
Member
@ankush ankush commented Jan 12, 2024

Requires MariaDB 10.6+

ref: https://mariadb.com/kb/en/select/#skip-locked

Why? Reduces lock timeout / deadlock problems in certain cases (think job queues where you want to skip WIP/locked jobs without using read committed isolation level)

image

no-docs

@ankush ankush requested review from a team and shariquerik and removed request for a team January 12, 2024 17:30
@ankush ankush enabled auto-merge (squash) January 12, 2024 17:59
@ankush ankush added the backport version-15-hotfix Backport the PR to v15 label Jan 12, 2024
@ankush ankush disabled auto-merge January 13, 2024 04:19
@ankush ankush merged commit e45e313 into frappe:develop Jan 13, 2024
@ankush ankush deleted the skip_locked branch January 13, 2024 04:19
mergify bot pushed a commit that referenced this pull request Jan 13, 2024
ankush added a commit that referenced this pull request Jan 13, 2024
(cherry picked from commit e45e313)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Jan 16, 2024
# [15.10.0](v15.9.0...v15.10.0) (2024-01-16)

### Bug Fixes

* add a check for `gpg` existing ([f0d65f1](f0d65f1))
* add empty space for notification mark read ([#24276](#24276)) ([e566f51](e566f51))
* check if autoname is promt before setting __newname ([9f08ab2](9f08ab2))
* collapse sidebar on picking workspace ([#24312](#24312)) ([#24314](#24314)) ([b3ef407](b3ef407))
* convert status field data to String before guessing the style ([#24226](#24226)) ([#24289](#24289)) ([1f5fb04](1f5fb04))
* don't add fallback for child table ([#24105](#24105)) ([1de3db8](1de3db8))
* Error when displaying dashboard with number card using average and sum functions ([#23883](#23883)) ([#24287](#24287)) ([5cc2281](5cc2281))
* Handle edge case while searching in current context ([460e1c2](460e1c2))
* include workspaces without domain restriction ([2f21a76](2f21a76))
* Make as_iterator work when there are no child queries ([55a26bf](55a26bf))
* **minor:** add optional chaining for this.$input ([#24340](#24340)) ([1302f08](1302f08))
* **minor:** check if markdown_preview exists ([#24336](#24336)) ([b512ad9](b512ad9))
* **minor:** increase rate limit for web form ([#24295](#24295)) ([#24297](#24297)) ([f1c139d](f1c139d))
* **minor:** return if no steps are defined. ([#24338](#24338)) ([373b0d4](373b0d4))
* misc ([#24303](#24303)) ([#24305](#24305)) ([3d515f2](3d515f2))
* mobile sidebar disappearing ([#24316](#24316)) ([#24342](#24342)) ([b21671b](b21671b))
* **mobile-ui:** tabs should scroll instead of stack ([#24309](#24309)) ([#24311](#24311)) ([fccf204](fccf204))
* **MultiCheck:** Use df.sort_options to enable/disable sort ([#24202](#24202)) ([#24291](#24291)) ([2a87904](2a87904))
* pass parent doctype on dashboard chart ([#24236](#24236)) ([#24238](#24238)) ([5a506dd](5a506dd))
* print perm check logs from DB query (backport [#24263](#24263)) ([#24268](#24268)) ([74eaaa5](74eaaa5))
* **response:** fixup non-ASCII character filenames ([9c6a58e](9c6a58e))
* sanitize html instead of escaping when creating/updating workspace ([#24284](#24284)) ([0be6579](0be6579))
* select field should not have debounce ([dc076e1](dc076e1))
* **sentry:** set scope for background jobs ([ed21f11](ed21f11))
* set correct recipient when reply to own email ([#24256](#24256)) ([#24260](#24260)) ([0b5923f](0b5923f))
* translate show all activity label ([#24363](#24363)) ([#24364](#24364)) ([4d2c3e5](4d2c3e5))
* **UX:** show status indicator in moblie view ([#24306](#24306)) ([#24308](#24308)) ([5940ce5](5940ce5))

### Features

* `frappe.db.sql` results `as_iterator` (backport [#19810](#19810)) ([#24346](#24346)) ([99a3a35](99a3a35)), closes [#24365](#24365)
* Skip locked rows while selecting ([#24298](#24298)) ([#24302](#24302)) ([09ef3d6](09ef3d6))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
@ankush ankush added the backport version-14-hotfix backport to version 14 label Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0