fix(MultiCheck): Use df.sort_options to enable/disable sort (backport #24202) #24290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When df.sort_options is null/undefined/truthy, then sort options. When df.sort_options is explicitely falsy, then do NOT sort options. (cherry picked from commit c9cccf0)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
## [14.62.3](v14.62.2...v14.62.3) (2024-01-16) ### Bug Fixes * add a check for `gpg` existing ([db2fb36](db2fb36)) * collapse sidebar on picking workspace ([#24312](#24312)) ([#24313](#24313)) ([898c803](898c803)) * delete existing children first to avoid `UniqueValidationError` (backport [#24140](#24140)) ([0363371](0363371)) * don't update docstatus (backport [#24216](#24216)) ([#24220](#24220)) ([6d4dcf9](6d4dcf9)) * Error when displaying dashboard with number card using average and sum methods ([#24244](#24244)) ([7d75ed3](7d75ed3)) * Handle edge case while searching in current context ([b4d23ed](b4d23ed)) * include workspaces without domain restriction ([90d4734](90d4734)) * **minor:** add optional chaining for this.$input ([#24339](#24339)) ([65a642f](65a642f)) * **minor:** check if markdown_preview exists ([#24335](#24335)) ([8fbda2c](8fbda2c)) * **minor:** increase rate limit for web form ([#24295](#24295)) ([#24296](#24296)) ([49ddaa0](49ddaa0)) * misc (backport [#24303](#24303)) ([#24304](#24304)) ([bd3f89b](bd3f89b)) * mobile sidebar disappearing ([#24316](#24316)) ([#24341](#24341)) ([b5811b5](b5811b5)) * **mobile-ui:** tabs should scroll instead of stack (backport [#24309](#24309)) ([#24310](#24310)) ([5db8d08](5db8d08)) * **MultiCheck:** Use df.sort_options to enable/disable sort ([#24202](#24202)) ([#24290](#24290)) ([1aa1de2](1aa1de2)) * pass parent doctype on dashboard chart ([#24236](#24236)) ([#24237](#24237)) ([e9c10f4](e9c10f4)) * print perm check logs from DB query (backport [#24263](#24263)) ([#24267](#24267)) ([ce9fd66](ce9fd66)) * remove unknown column `indicator_color` ([8f6be35](8f6be35)) * **response:** fixup non-ASCII character filenames ([9dc059b](9dc059b)) * set correct recipient when reply to own email ([#24256](#24256)) ([#24259](#24259)) ([97fea1f](97fea1f)) * strip html instead of escaping when creating/updating workspace (backport [#24284](#24284)) ([8207559](8207559)) * **UX:** show status indicator in moblie view ([#24306](#24306)) ([#24307](#24307)) ([d74b5fc](d74b5fc)) ### Reverts * Revert "fix(Data Import): show failed import logs" ([56c9383](56c9383))
|
🎉 This PR is included in version 14.62.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #24202 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com