fix: Broken IMAP account disabling logic (backport #24118) #24130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 807cfd6)
redis set/get don't consider site (cherry picked from commit 71908f1) # Conflicts: # frappe/email/doctype/email_account/email_account.py
This doesn't work because when email is broken we still continue and down the line changes get rolled back. (cherry picked from commit 3836d94)
assign_to expects a list of strings of users not a single string. (cherry picked from commit cc2bb85) # Conflicts: # frappe/tests/test_email.py
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
## [14.62.2](v14.62.1...v14.62.2) (2024-01-10) ### Bug Fixes * Allowed standard fields in data export ( creation, owner) (backport [#24187](#24187)) ([#24190](#24190)) ([73a0f20](73a0f20)) * ambiguous linked tables ([#24214](#24214)) ([4c5dab7](4c5dab7)) * broken `dynamic_link` to `link` formatting in query report (backport [#24054](#24054)) ([#24087](#24087)) ([ea78f39](ea78f39)) * Broken IMAP account disabling logic (backport [#24118](#24118)) ([#24130](#24130)) ([fbd0404](fbd0404)) * **communication:** don't change email case ([51562b4](51562b4)) * copy content on reply ([399ab3f](399ab3f)) * extract the frappe version from backup header directly ([ee9f28f](ee9f28f)) * number card only gives integer ([#24047](#24047)) ([#24137](#24137)) ([3ebd3a6](3ebd3a6)) * **OTP:** Autofocus OTP input, fix placeholder ([#24203](#24203)) ([#24204](#24204)) ([4d59a87](4d59a87)) * **recorder:** Normalize `IN` in SQL queries ([#24132](#24132)) ([#24133](#24133)) ([a8da916](a8da916)) * use correct parent field in rebuild_tree() ([#24107](#24107)) ([#24120](#24120)) ([5d8a825](5d8a825)) * **Web Form:** make button label translatable ([#24122](#24122)) ([1da33fd](1da33fd))
|
🎉 This PR is included in version 14.62.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #24118 done by Mergify.
Cherry-pick of 71908f1 has failed:
Cherry-pick of cc2bb85 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com