8000 fix: set ignore_permissions on get_receiver_list in notification.py (backport #24144) by mergify[bot] · Pull Request #24198 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: set ignore_permissions on get_receiver_list in notification.py (backport #24144) #24198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Jan 8, 2024

This is an automatic backport of pull request #24144 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…no receiver list

Similar to fetching the email list in `get_list_of_recipients()`, the `get_info_based_on_role` call to fetch `mobile_no` in `get_receiver_list()` should set `ignore_permissions` in order to allow sms notifications to send based on actions of limited and anonymous users (e.g. web form submissions).

(cherry picked from commit 4ec4594)
@mergify mergify bot requested review from a team and ankush and removed request for a team January 8, 2024 12:19
@surajshetty3416 surajshetty3416 merged commit eaa4f04 into version-15-hotfix Jan 8, 2024
@surajshetty3416 surajshetty3416 deleted the mergify/bp/version-15-hotfix/pr-24144 branch January 8, 2024 12:20
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Jan 8, 2024
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
0